----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100224/#review594 -----------------------------------------------------------
I'm mostly concerned about the way the animation is done. The rest seems nice to me ! :) src/mainview.cpp <http://git.reviewboard.kde.org/r/100224/#comment436> Style: no need to add an extra blank line with whitespace... src/tabbar.cpp <http://git.reviewboard.kde.org/r/100224/#comment437> I can't say I'm a big fan of the timer-based approach, especially with the animation framework that's been in Qt since 4.6, I think it'd be more elegant. - Pierre On 2010-12-20 23:08:46, Felix Rohrbach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100224/ > ----------------------------------------------------------- > > (Updated 2010-12-20 23:08:46) > > > Review request for rekonq. > > > Summary > ------- > > This patch highlights inactive tabs if their title has changed, so people get > aware of changes in the tabs (for instance a new message in a chat window). > > Patch by fritz_van_tom. > > It's a nice patch, but maybe we should remove the blinking, as this is very > distracting. > > I don't have a kde git account, so please merge it if you like it. > > > Diffs > ----- > > src/mainview.cpp 850101e > src/tabbar.h acd8e2f > src/tabbar.cpp 286d7d4 > > Diff: http://git.reviewboard.kde.org/r/100224/diff > > > Testing > ------- > > compiles and works > > > Thanks, > > Felix > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
