----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100286/#review709 -----------------------------------------------------------
src/newtabpage.cpp <http://git.reviewboard.kde.org/r/100286/#comment510> Add a space between the if and the parenthesis. In Qt/KDE style, you need bracket in both if either the if() or else() needs them. The conditition in the if is unreadable. I would use temp variables to make it clear what is going on. src/newtabpage.cpp <http://git.reviewboard.kde.org/r/100286/#comment511> No spaces around the QL1S(). src/newtabpage.cpp <http://git.reviewboard.kde.org/r/100286/#comment512> Spaces on empty line. src/previewselectorbar.cpp <http://git.reviewboard.kde.org/r/100286/#comment513> This text misses the i18n(). src/previewselectorbar.cpp <http://git.reviewboard.kde.org/r/100286/#comment515> Missing some QL1S() src/previewselectorbar.cpp <http://git.reviewboard.kde.org/r/100286/#comment514> This else needs brackets according to the coding convention of Qt/KDE. src/websnap.h <http://git.reviewboard.kde.org/r/100286/#comment516> ? converting for KDE style to WebKit style? src/websnap.cpp <http://git.reviewboard.kde.org/r/100286/#comment517> Space missing between the if and the parenthesis. I had no time to do a serious review but there are at least a few style errors to fix. The lineUrl problem are block IMHO. I will try to find the time for a real review after you update :) - Benjamin On 2011-01-02 17:23:31, Furkan Üzümcü wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100286/ > ----------------------------------------------------------- > > (Updated 2011-01-02 17:23:31) > > > Review request for rekonq. > > > Summary > ------- > > Added support for entering link directly into the Favorites section in the > New Tab . > > > Diffs > ----- > > src/websnap.h e5b550f > src/websnap.cpp 54cf105 > src/newtabpage.cpp 7dcc958 > src/previewselectorbar.h 9684a01 > src/previewselectorbar.cpp c8ab5b0 > > Diff: http://git.reviewboard.kde.org/r/100286/diff > > > Testing > ------- > > * Tested and works! > > > Thanks, > > Furkan > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
