----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100316/#review762 -----------------------------------------------------------
Ship it! Really cool. I like when a cleaning patch have more - than + :) - Benjamin On 2011-01-07 21:17:27, Pierre Rossi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100316/ > ----------------------------------------------------------- > > (Updated 2011-01-07 21:17:27) > > > Review request for rekonq and Benjamin Poulain. > > > Summary > ------- > > I believe we don't need static members in QWeakPointers for all the > *Managers, static getter functions would do the job. > > > This addresses bug N/A. > /show_bug.cgi?id=N/A > > > Diffs > ----- > > src/application.h b30e337 > src/application.cpp 466a0a4 > > Diff: http://git.reviewboard.kde.org/r/100316/diff > > > Testing > ------- > > "compiles and runs" ™ > > > Thanks, > > Pierre > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
