----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100253/#review767 -----------------------------------------------------------
src/mainview.cpp <http://git.reviewboard.kde.org/r/100253/#comment579> Shouldn't that take into account the full size of m_cornerWidget? Having a layout means having margins on some style. And you are adding a stretch: cornerLayout->addStretch(); src/mainview.cpp <http://git.reviewboard.kde.org/r/100253/#comment580> If you are checking for the full widget size (previous comment), this if() should probably be done before the previous if() at line 147. src/mainview.cpp <http://git.reviewboard.kde.org/r/100253/#comment581> Interesting. This is needed despite m_cornerWidget->setSizePolicy(QSizePolicy::Minimum, QSizePolicy::Minimum); ? src/mainview.cpp <http://git.reviewboard.kde.org/r/100253/#comment582> Again, I think you should take into account the full widget size to be correct. Do you know in which case this line is needed? The above condition is a mistery to me :) src/mainview.cpp <http://git.reviewboard.kde.org/r/100253/#comment578> You forgot a kdebug() here :) src/mainwindow.cpp <http://git.reviewboard.kde.org/r/100253/#comment577> This change seems totally unrelated. Why is that needed? - Benjamin On 2011-01-02 11:06:47, Felix Rohrbach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100253/ > ----------------------------------------------------------- > > (Updated 2011-01-02 11:06:47) > > > Review request for rekonq. > > > Summary > ------- > > This patch adds a tool button to the corner widget of the tab widget which > shows a list of the current open tabs. In contrast to the open new tab button > this button is always in the top right edge. > > If you don't like to download the patch, you can also use my git clone on > github: > Clone: git://github.com/Fxrh/rekonq.git > Branch: tabListButton > > > Diffs > ----- > > src/mainview.h 1d04d28 > src/mainview.cpp 850101e > src/mainwindow.cpp 3a9c124 > > Diff: http://git.reviewboard.kde.org/r/100253/diff > > > Testing > ------- > > Tested and works well. > > > Thanks, > > Felix > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
