----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100324/#review784 -----------------------------------------------------------
Ship it! src/tabbar.cpp <http://git.reviewboard.kde.org/r/100324/#comment588> It could be: const int tabIndex = tabAt(event->pos()); - Benjamin On Jan. 8, 2011, 9:25 p.m., Furkan Üzümcü wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100324/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2011, 9:25 p.m.) > > > Review request for rekonq. > > > Summary > ------- > > When showing tab preview Rekonq uses a while loop to find the tab under the > cursor. I think that isn't a really good way of doing it. As I'm not a really > good developer my thought would be wrong, but I think using tabAt(const > QPoint &position) would be better. > > > Diffs > ----- > > src/tabbar.cpp 5712497 > > Diff: http://git.reviewboard.kde.org/r/100324/diff > > > Testing > ------- > > * Tested and works. > > > Thanks, > > Furkan > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
