> On Jan. 9, 2011, 9:35 a.m., Andrea Diamantini wrote: > > The patch seems good and I'm going to merge it. But... did you notice you > > changed also bookmarks panel behavior? Is this silently intended? > > > > Second, the "tested and works" string you add to the testing done is > > completely unuseful. If your feature does not compile, and if you didn't > > test it, why did you ask for a review/merge request? There you have to > > write WHAT you do to test it. Unit tests? Static tests? Manual tests? etc...
I do because that search is used by the others too. - Furkan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100310/#review798 ----------------------------------------------------------- On Jan. 8, 2011, 12:14 a.m., Furkan Üzümcü wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100310/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2011, 12:14 a.m.) > > > Review request for rekonq. > > > Summary > ------- > > Added support for automatically expanding the grouped search results in > history panel by default. > > > Diffs > ----- > > src/urlpanel.h 42ff85f > src/urlpanel.cpp d7ddd89 > > Diff: http://git.reviewboard.kde.org/r/100310/diff > > > Testing > ------- > > * Tested and works! > > > Thanks, > > Furkan > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
