----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100374/#review999 -----------------------------------------------------------
Code seems good, but... why don't we create the menu just on aboutToShow() signal emitted? This way we have no settings to change on the fly or menus to hide/show. What do you guys think? - Andrea On Jan. 18, 2011, 2:02 p.m., Felix Rohrbach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100374/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2011, 2:02 p.m.) > > > Review request for rekonq. > > > Summary > ------- > > This patch contains the changes to the context menu which we decided in our > meeting: > > 1. Hide new tab entry if it is not necessary. > 2. Print and Search action: I removed the print action. The search action is > now in the "search with" submenu if some text is selected. > 3. Hide the development menu entries and add an option to show them. > > Clone: git://anongit.kde.org/clones/rekonq/felixr/rekonq > Branch: meetingMenuChanges > > > Diffs > ----- > > src/application.cpp f38832c > src/mainwindow.h 02cd723 > src/mainwindow.cpp 59fff83 > > Diff: http://git.reviewboard.kde.org/r/100374/diff > > > Testing > ------- > > > Thanks, > > Felix > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
