----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100312/#review1073 -----------------------------------------------------------
src/mainwindow.cpp <http://git.reviewboard.kde.org/r/100312/#comment873> These 2 signals are (obviously) the same one. Please, remove one src/mainwindow.cpp <http://git.reviewboard.kde.org/r/100312/#comment875> Why are you doing this? You are in the MainWindow class, so use the "this" pointer. src/rekonq.kcfg <http://git.reviewboard.kde.org/r/100312/#comment874> Default setting has to be the old one. So set this to false. src/webview.cpp <http://git.reviewboard.kde.org/r/100312/#comment876> Why we have another function doing the SAME thing the one in MainWindow does? I guess one has to be removed. - Andrea On Jan. 25, 2011, 7:15 a.m., Furkan Üzümcü wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100312/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2011, 7:15 a.m.) > > > Review request for rekonq. > > > Summary > ------- > > Added an option, so that people who would like to have the Favicon of the > current website as the icon of rekonq’s window, can enable it. > > > Diffs > ----- > > src/application.cpp f38832c > src/mainview.cpp 699103a > src/mainwindow.h c915934 > src/mainwindow.cpp ece11cc > src/rekonq.kcfg d7d496f > src/settings/settings_appearance.ui f7dd474 > src/tabbar.cpp 7a8419a > src/webview.h a06a2cb > src/webview.cpp d3eb2f4 > > Diff: http://git.reviewboard.kde.org/r/100312/diff > > > Testing > ------- > > * Tested and works! > > > Thanks, > > Furkan > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
