----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100575/#review1250 -----------------------------------------------------------
It works fine! and it's a really good patch, thanks for that. All I can say is there is an empty line with spaces (line number 199 in src/mainwindow.h) and I guess the 223rd line in urlbar.cpp should be if (text().isEmpty() && progr == 0 && !m_urlPreview->isVisible()) Sorry for a short review I don't really have enough knowledge for those code to review them. - Furkan On Feb. 5, 2011, 12:55 p.m., Johannes Tröscher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100575/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2011, 12:55 p.m.) > > > Review request for rekonq, Andrea Diamantini, Pierre Rossi, and Benjamin > Poulain. > > > Summary > ------- > > firefox4-like urlpreview. replaces the preview popup at the lower left corner. > i don't have a kde-git account, so please merge it if you like it. > > > Diffs > ----- > > src/CMakeLists.txt 7f9fe19 > src/mainwindow.h 598d66e > src/mainwindow.cpp 943f877 > src/urlbar/urlbar.h 964534c > src/urlbar/urlbar.cpp f963be0 > src/urlbar/urlpreview.h PRE-CREATION > src/urlbar/urlpreview.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/100575/diff > > > Testing > ------- > > compiles and works. > > > Screenshots > ----------- > > urlPreview > http://git.reviewboard.kde.org/r/100575/s/71/ > > > Thanks, > > Johannes > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
