----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100320/#review1260 -----------------------------------------------------------
src/bookmarks/bookmarkstoolbar.cpp <http://git.reviewboard.kde.org/r/100320/#comment1050> event->type() check is not yet a switch check. src/bookmarks/bookmarkstoolbar.cpp <http://git.reviewboard.kde.org/r/100320/#comment1046> Is a static_cast really ok, here? src/bookmarks/bookmarkstoolbar.cpp <http://git.reviewboard.kde.org/r/100320/#comment1048> I don't like logic here. Sure you need to not exit anyway? src/bookmarks/bookmarkstoolbar.cpp <http://git.reviewboard.kde.org/r/100320/#comment1047> Same from !405 applies here. src/bookmarks/bookmarkstoolbar.cpp <http://git.reviewboard.kde.org/r/100320/#comment1049> This QCursor::pos() is probably the same case to eliminate. - Andrea On Feb. 5, 2011, 10:20 p.m., Furkan Üzümcü wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100320/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2011, 10:20 p.m.) > > > Review request for rekonq. > > > Summary > ------- > > Added support for opening a bookmarks folder in tabs by middle clicking. > > > Diffs > ----- > > src/bookmarks/bookmarkstoolbar.cpp e239e23 > > Diff: http://git.reviewboard.kde.org/r/100320/diff > > > Testing > ------- > > * Tested and works. > > > Thanks, > > Furkan > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
