On Mon, Feb 7, 2011 at 22:52, Andrea Diamantini <[email protected]> wrote:
> This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100538/ > > On February 7th, 2011, 9:21 p.m., *Pierre Rossi* wrote: > > > src/mainwindow.cpp<http://git.reviewboard.kde.org/r/100538/diff/5/?file=8552#file8552line1123> > (Diff > revision 5) > > bool MainWindow::event(QEvent *event) > > 1115 > > QKeyEvent *kev = static_cast<QKeyEvent *>(event); > > What if it's a QShortcutEvent ? > > I'm seeing in the docs that QEvent::ShortcutOverride && QEvent::KeyPress ARE > QKeyEvent(s). So, the assertion and the static_cast are safe. Am I missing > something? > > > My bad ! I never used it before and the name lead me to believe it was a QShortcutEvent, you're absolutely right, then everything is fine for me too. Just fix the whitespace and "Ship It !"™ Cheers, -- Pierre
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
