----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100628/#review1349 -----------------------------------------------------------
src/application.cpp <http://git.reviewboard.kde.org/r/100628/#comment1110> Storing an index looks dangerous. The available encoding can vary if you add QtTextCodecPlugins. I would store the name of the encoding. src/application.cpp <http://git.reviewboard.kde.org/r/100628/#comment1111> Isn't latin 1 twice in the list like that? - Benjamin On Feb. 10, 2011, 11:56 p.m., Andrea Diamantini wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100628/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2011, 11:56 p.m.) > > > Review request for rekonq. > > > Summary > ------- > > This patch cleans up encoding management, moving code to its real position: > The appearance settings widget. > > > In fact our code is actually changing "default" text encoding, not the page > one "on the fly" > > > Diffs > ----- > > src/application.cpp a49e1d8 > src/mainwindow.h 00bd40a > src/mainwindow.cpp 9509e63 > src/rekonq.kcfg 704d54b > src/settings/appearancewidget.h e269617 > src/settings/appearancewidget.cpp c444f72 > src/settings/settings_appearance.ui b25af43 > src/webpage.cpp 791bb36 > > Diff: http://git.reviewboard.kde.org/r/100628/diff > > > Testing > ------- > > apply, compile, execute, test :) > > > Thanks, > > Andrea > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
