----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100661/#review1514 -----------------------------------------------------------
src/mainview.cpp <http://git.reviewboard.kde.org/r/100661/#comment1277> This is a strange call site for this. Not to mention MainView::webStop() does not do anything if currentUrlBar()->completionBox().data()->isVisible(), this is really counter-intuitive. - Benjamin On Feb. 17, 2011, 7:10 p.m., Furkan Üzümcü wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100661/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2011, 7:10 p.m.) > > > Review request for rekonq. > > > Summary > ------- > > The issue is solved by changing the webStop() function in mainView. That > function is only used by the stop action. > > > Diffs > ----- > > src/mainview.cpp dfa202d > src/mainwindow.cpp 24dc865 > src/urlbar/urlbar.h 964534c > > Diff: http://git.reviewboard.kde.org/r/100661/diff > > > Testing > ------- > > Compiles and works. > > > Thanks, > > Furkan > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
