----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100316/#review1610 -----------------------------------------------------------
src/application.h <http://git.reviewboard.kde.org/r/100316/#comment1375> I was thinking again here... why don't we get rid of these, too? - Andrea On Feb. 22, 2011, 1:48 p.m., Pierre Rossi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100316/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2011, 1:48 p.m.) > > > Review request for rekonq and Benjamin Poulain. > > > Summary > ------- > > I believe we don't need static members in QWeakPointers for all the > *Managers, static getter functions would do the job. > > > This addresses bug N/A. > /show_bug.cgi?id=N/A > > > Diffs > ----- > > src/application.h b30e337 > src/application.cpp 9702c13 > src/bookmarks/bookmarkowner.cpp b7aa4a4 > src/bookmarks/bookmarkprovider.cpp e4fb9e3 > src/bookmarks/bookmarkspanel.cpp 1763a1e > src/bookmarks/bookmarkstoolbar.cpp e239e23 > src/bookmarks/bookmarkstreemodel.cpp f13cee4 > src/history/historymodels.cpp d9d3efe > src/history/historypanel.cpp d1b02c4 > src/iconmanager.cpp f5b60ea > src/mainview.cpp dfa202d > src/mainwindow.cpp 24dc865 > src/networkaccessmanager.cpp 118d4b2 > src/newtabpage.cpp 7dcc958 > src/opensearch/searchengine.cpp f407789 > src/paneltreeview.cpp e44fa5f > src/previewselectorbar.cpp c8ab5b0 > src/protocolhandler.cpp 6dfc33a > src/sessionmanager.cpp 87f25f4 > src/settings/generalwidget.cpp 0128830 > src/settings/settingsdialog.cpp 84c6da1 > src/tabbar.cpp be20ecd > src/urlbar/bookmarkwidget.cpp 4569bc2 > src/urlbar/completionwidget.cpp 0d2026a > src/urlbar/listitem.cpp 1794233 > src/urlbar/rsswidget.cpp b29ed0e > src/urlbar/urlbar.cpp c0edc9d > src/urlbar/urlresolver.h 43a4a43 > src/urlbar/urlresolver.cpp 3797f51 > src/webicon.cpp e64db30 > src/webpage.cpp b44b2e4 > src/webtab.cpp c2f0016 > src/webview.cpp 18c7a73 > src/zoombar.cpp 8679126 > > Diff: http://git.reviewboard.kde.org/r/100316/diff > > > Testing > ------- > > "compiles and runs" ™ > > > Thanks, > > Pierre > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
