> On April 4, 2011, 8:29 a.m., Andrea Diamantini wrote: > > src/mainwindow.cpp, line 499 > > <http://git.reviewboard.kde.org/r/101019/diff/2/?file=13727#file13727line499> > > > > Why? > > Felix Rohrbach wrote: > Up to now, the close shortcuts were used to close tabs, so when I added > the standard close action, the shortcuts were used two times. My resolution > was to give the tab close the primary shortcut of KStandardAction::close > (CTRL+W) and the window close the alternate shortcut (CTRL+Esc). Maybe I can > write that a bit cleaner...
Ah.. now it's clear, thanks. Let me just point out that the close action (and hence shortcut) is defined for closing a "document/tab". - Andrea ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101019/#review2376 ----------------------------------------------------------- On April 4, 2011, 1 p.m., Felix Rohrbach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101019/ > ----------------------------------------------------------- > > (Updated April 4, 2011, 1 p.m.) > > > Review request for rekonq. > > > Summary > ------- > > The quit action in the action collection did just close the current rekonq > window instead of quitting the application, so I added a close action and > fixed the quit action. > > branch: quitClose > > > This addresses bug 268578. > /show_bug.cgi?id=268578 > > > Diffs > ----- > > src/mainwindow.cpp 3489841 > > Diff: http://git.reviewboard.kde.org/r/101019/diff > > > Testing > ------- > > > Thanks, > > Felix > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
