----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101027/ -----------------------------------------------------------
Review request for rekonq. Summary ------- Hi, I'm not 100% sure but I tend to think you must not set a QApplication as the parent of a BookmarkProvider. I think the problem is that any BookmarkProvider has QWidgets in its tree of QObjects. Therefore, you will get problems when deleting the children because of this: http://bugreports.qt.nokia.com/browse/QTBUG-16974 So I just deleted some objects in Application::~Application in order to make sure these objects are deleted before the QApplication. Just deleting the BookmarkProvider in Application::~Application would be enough to fix the crash here, but I'm deleting the other objects ... 1 ... because if now or in the future these objects had a QWidget in its object tree I think you might get a crash. 2 ... just in case. By the way, I think the bug mentioned in this request was introduced in this commit 2b4efa406780920631af1166e79d54e54092322a I have push permissions, if you give me the ok I will push this patch to 0.7-branch. This addresses bug 269490. /show_bug.cgi?id=269490 Diffs ----- src/application.cpp 7fcbfe8 Diff: http://git.reviewboard.kde.org/r/101027/diff Testing ------- I have built rekonq with the patch; problem solved for me. Thanks, José Manuel
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
