> On April 5, 2011, 10:28 p.m., Andrea Diamantini wrote:
> > src/webpage.cpp, line 800
> > <http://git.reviewboard.kde.org/r/100895/diff/2/?file=13166#file13166line800>
> >
> >     I don't see the need for replicating this code here. Call the usual 
> > loadUrl slot and let rekonq do its job...

loadUrl works only for the currentTab. Here we want to refresh even inactive 
ones.


- Yoann


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100895/#review2419
-----------------------------------------------------------


On April 5, 2011, 10:30 p.m., Yoann Laissus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100895/
> -----------------------------------------------------------
> 
> (Updated April 5, 2011, 10:30 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Refresh all "about:bookmarks" pages when bookmarks are updated
> 
> 
> Diffs
> -----
> 
>   src/bookmarks/bookmarkprovider.cpp cef6eae 
>   src/protocolhandler.cpp 36efe2a 
>   src/webpage.h 09977bf 
>   src/webpage.cpp 3e2798d 
>   src/webview.cpp 16c9c2e 
> 
> Diff: http://git.reviewboard.kde.org/r/100895/diff
> 
> 
> Testing
> -------
> 
> It works.
> 
> 
> Thanks,
> 
> Yoann
> 
>

_______________________________________________
rekonq mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/rekonq

Reply via email to