> On April 7, 2011, 10:34 p.m., Pierre Rossi wrote: > > src/mainview.cpp, line 104 > > <http://git.reviewboard.kde.org/r/100604/diff/3/?file=13938#file13938line104> > > > > do we really need this all foreach loop ? It doesn't seem very likely > > to me that two closed tabs will have the same history... > > Anton Kreuzkamp wrote: > I don't see a better way currently.. (I'll have a look at it again)
There would be just the possibility to inherit TabHistory from QVariant and ship it as KAction::data(), but I'm not sure if this is a good approach. - Anton ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100604/#review2480 ----------------------------------------------------------- On April 8, 2011, 2:51 p.m., Anton Kreuzkamp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100604/ > ----------------------------------------------------------- > > (Updated April 8, 2011, 2:51 p.m.) > > > Review request for rekonq. > > > Summary > ------- > > Restore the history of the tab when restoring a tab from the list of closed > tabs, by open last closed tab or by restoring the session. > Therefore I ported the session-file to xml, as it allows more complex > session-files (which is also needed for multiple sessions support). > (Doesn't require a qtwebkit-patch anymore) > > > Diffs > ----- > > src/mainview.h acc2d8c > src/application.cpp 1fe936f > src/history/historymanager.h eb8d78d > src/mainview.cpp b34acc3 > src/newtabpage.cpp a598066 > src/sessionmanager.h 2297290 > src/sessionmanager.cpp 68bc635 > src/tabbar.cpp 1ab357f > > Diff: http://git.reviewboard.kde.org/r/100604/diff > > > Testing > ------- > > tested and everything seems to work fine. > > > Thanks, > > Anton > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
