> On April 20, 2011, 5:18 p.m., Andrea Diamantini wrote: > > src/mainwindow.h, line 218 > > <http://git.reviewboard.kde.org/r/101043/diff/4/?file=14787#file14787line218> > > > > We use a different syntax for member variables (with the m_ at the > > beginning). > > Please, use it. > > Pierre Rossi wrote: > Actually in that case I'd be in favor of dropping the member altogether > since it's not needed once it's been created and connected (and parented so > it gets deleted with the MainWindow instance).
Ah Pierre, I just noticed the "Shipit" and passed on... Yes. I prefer your solution. - Andrea ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101043/#review2766 ----------------------------------------------------------- On April 19, 2011, 10:35 p.m., Thomas Murach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101043/ > ----------------------------------------------------------- > > (Updated April 19, 2011, 10:35 p.m.) > > > Review request for rekonq. > > > Summary > ------- > > This patch adds the following functionality: Pressing Ctrl + 1 up to Ctrl + 9 > will load the favorite page with number 1 ... 9 in the current tab. I find > this very useful when using Opera. > This is my first patch. So please tell me if there is something to improve in > my kind of coding / formatting / ... > The code itself is pretty much copied from the function SwitchToTab() in > MainView. > Numbers higher than 9 do not make sense as shortcuts (in my opinion) and are > therefore omitted, as well as zero > > > Diffs > ----- > > src/mainview.h acc2d8c > src/mainview.cpp b34acc3 > src/mainwindow.h 9853ca3 > src/mainwindow.cpp 7b4e3ee > > Diff: http://git.reviewboard.kde.org/r/101043/diff > > > Testing > ------- > > Yes. Couldn't find any problems. > For example pressing Ctrl + _Number_X_ doesn't crash if you have less than > _Number_X_ favorite pages > > > Thanks, > > Thomas > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
