> On April 21, 2011, 8:03 a.m., Andrea Diamantini wrote: > > I like this. My concern about is that I don't clearly see the differences > > between the feature and the fixes ;) > >
All the fixes are in bookmarktoolbar.cpp. :) And the rest of the code is to add set/unset in the bookmark context menu. - Yoann ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101128/#review2798 ----------------------------------------------------------- On April 14, 2011, 9:09 p.m., Yoann Laissus wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101128/ > ----------------------------------------------------------- > > (Updated April 14, 2011, 9:09 p.m.) > > > Review request for rekonq. > > > Summary > ------- > > - A new option to set/unset the current bookmark bar folder in the context > menu > - Fix drag and drop with a custom folder > - Fix a regression which affects BK bar drag and drop (5a53d2bf91dd) > > > Diffs > ----- > > src/bookmarks/bookmarkowner.h 8f0cd3b > src/bookmarks/bookmarkowner.cpp bfca6ef > src/bookmarks/bookmarkscontextmenu.cpp a55f777 > src/bookmarks/bookmarkstoolbar.cpp 3667503 > > Diff: http://git.reviewboard.kde.org/r/101128/diff > > > Testing > ------- > > Works well > > > Thanks, > > Yoann > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
