----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102065/#review5046 -----------------------------------------------------------
Andrea, can you clarify a bit what the problem is with moving the logic to MainWindow ? I'm not sure to get it and I actually liked this approach better... :/ src/mainwindow.cpp <http://git.reviewboard.kde.org/r/102065/#comment4497> You could probably rephrase that comment while you're at it. - Pierre On July 24, 2011, 7:50 a.m., Tirtha Chatterjee wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102065/ > ----------------------------------------------------------- > > (Updated July 24, 2011, 7:50 a.m.) > > > Review request for rekonq. > > > Summary > ------- > > For my GSoC project of sessions management, I need to be able to load URLs in > specific windows. The use case is basically this -- > I drag a tab from an inactive session, and drop it into an active session. > So the URL of the inactive session should get loaded into specifically that > window which corresponds to the active session. So I moved the loadUrl > functionality to MainWindow. But I kept Application::loadUrl, it just passes > on the task to the appropriate window's loadUrl method. > > > Diffs > ----- > > src/application.h cc9bc43 > src/application.cpp 8bca4f6 > src/mainwindow.h e7a5207 > src/mainwindow.cpp e4bddd1 > > Diff: http://git.reviewboard.kde.org/r/102065/diff > > > Testing > ------- > > Tested. Works correctly. > > > Thanks, > > Tirtha > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
