----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102105/#review5151 -----------------------------------------------------------
src/mainwindow.cpp <http://git.reviewboard.kde.org/r/102105/#comment4646> Is there a reason because you removed this? src/mainwindow.cpp <http://git.reviewboard.kde.org/r/102105/#comment4647> Can you pls add a comment here explaining what it is happening? - Andrea On July 27, 2011, 8:32 p.m., Johannes Tröscher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102105/ > ----------------------------------------------------------- > > (Updated July 27, 2011, 8:32 p.m.) > > > Review request for rekonq and Andrea Diamantini. > > > Summary > ------- > > this patch changes two things in the notifypopup: > first: it uses a QLabel that is drawn inside the window, instead of a > KPassivePopup > this makes possible, that you can view url-previews if the window is not the > active one and you hover a link > > second: it limits the size of the url-preview to the half size of the > browser-screen like in firefox4. > (it's a question of taste, i like it :D ) > > ...... > third: i think the code is a bit easier to read :) > > > Diffs > ----- > > src/mainwindow.h e7a5207 > src/mainwindow.cpp d0d4d40 > > Diff: http://git.reviewboard.kde.org/r/102105/diff > > > Testing > ------- > > compiles and works > > > Thanks, > > Johannes > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
