----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102170/#review5373 -----------------------------------------------------------
it's a very nice patch, i like the new layout of the rekonq menu especially. the only thing i've pointed out, is to make some variables const. one feature that would be very nice is a button that allows to update the adblock-defenitions immediately. src/adblock/adblockwidget.cpp <http://git.reviewboard.kde.org/r/102170/#comment4857> make that const src/adblock/adblockwidget.cpp <http://git.reviewboard.kde.org/r/102170/#comment4858> that one too src/adblock/adblockwidget.cpp <http://git.reviewboard.kde.org/r/102170/#comment4859> that one too src/adblock/adblockwidget.cpp <http://git.reviewboard.kde.org/r/102170/#comment4860> that one too src/adblock/adblockwidget.cpp <http://git.reviewboard.kde.org/r/102170/#comment4861> and that one src/adblock/adblockwidget.cpp <http://git.reviewboard.kde.org/r/102170/#comment4862> that one too src/adblock/adblockwidget.cpp <http://git.reviewboard.kde.org/r/102170/#comment4863> you don't need to define that one here.. src/adblock/adblockwidget.cpp <http://git.reviewboard.kde.org/r/102170/#comment4864> ..do it here and const :) - Johannes On Aug. 1, 2011, 10:12 a.m., Andrea Diamantini wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102170/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2011, 10:12 a.m.) > > > Review request for rekonq. > > > Summary > ------- > > This patch provides a "tools" menu, similar to the one provided by Google > Chrom*, to easily show/add our tools/extensions. > > > Diffs > ----- > > src/CMakeLists.txt 09c7531 > src/adblock/adblockmanager.h 1f716c6 > src/adblock/adblockmanager.cpp 6a4a382 > src/adblock/adblockwidget.h PRE-CREATION > src/adblock/adblockwidget.cpp PRE-CREATION > src/adblock/settings_adblock.ui PRE-CREATION > src/mainwindow.h e7a5207 > src/mainwindow.cpp 09e2ae1 > src/rekonq.kcfg 762fe94 > src/settings/adblockwidget.h 08194ad > src/settings/adblockwidget.cpp ad8bd59 > src/settings/settings_adblock.ui 68fcf52 > src/settings/settings_webkit.ui 00bced9 > src/settings/settingsdialog.cpp a8d5f5b > src/webview.cpp a938ad7 > > Diff: http://git.reviewboard.kde.org/r/102170/diff > > > Testing > ------- > > > Thanks, > > Andrea > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
