> On Aug. 18, 2011, 10:57 p.m., Andrea Diamantini wrote: > > I don't like this change. > > First, I couldn't find a similar option in Firefox or Chromium: they > > continued opening external links in new tabs. The only way to change it > > (just on Firefox) is to change exactly the same settings rekonq has. It > > seems impossible to provide this behavior on Chromium. > > Second, I usually open a lot of links from external tabs (eg: akregator, > > kmail). Why should I find them in different windows? > > > > Thomas Zander wrote: > Jumping in as this is a very similar subject to the other one I was > talking about on the rekonq mailinglist; > > people use virtual desktops and activities to separate out their work > into discrete sections. > Consider this usecase; (not uncommon!) > A personal activity runs kmail while at work, a work activity runs rekonq > with gmail for work emails. > The user clicks on a link in kmail to show a webpage that is clearly for > his personal activity; maybe a facebook link... > > Current behavior is that on his work activity, on another virtual > desktop, a tab is added next to his work gmail tab. > > With this patch (if I understand correctly) the click in kmail, on his > personal activity, opens a window in that same activity and on the same > virtual desktop. Which is much more predictable and in line with the > concepts that both virtual desktops and activities promote. > ps. did you know you can suspend an activity and that quits all windows > there? They save session and restarting the activity will restore that > session. Consider this with the above suggested behavior. > > Bottom line; if I understand this patch correctly, I like it!
Going about this from a user's perspective. Current behaviour, please correct me if I'm wrong, is that when open urls in new tabs is set and you open a url, it will open it in a new tab in the rekonq window on the current virtual desktop. If there is no rekonq on the current virtual desktop it will look for a rekonq window on another virtual desktop and open it there, and if there is no rekonq open, it will open a new window. If you want to split opened urls semantically between multiple virtual desktops you can decisively start up a new rekonq instance on your virtual desktop of choice. IMHO this is acceptable behaviour for the above described scenario. However, an optimal solution would probably be to have a setting that only the first url opened per virtual desktop opens a new window, while the next ones will open in a new tab in that window. Now looking at it from the perspective of Activities. Activities are something KDE specific, so naturally neither firefox nor chrome would know how to deal with them. But rekonq as KDE application could. Activities are meant to separate different tasks from each other. While I would still want urls to be opened by the same rekonq instance, that instance should ignore the fact that there is another rekonq instance running in another activity. It again would boil down to something like I explained for the previous scenario, only the first url opened per activity opens a new window. My 0.02$ - Heinz ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102330/#review5806 ----------------------------------------------------------- On Aug. 15, 2011, 3:30 p.m., Johannes Tröscher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102330/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2011, 3:30 p.m.) > > > Review request for rekonq. > > > Summary > ------- > > patch by Pali Rohár. > https://bugs.kde.org/show_bug.cgi?id=275477 > > > Diffs > ----- > > src/application.cpp a62d548 > src/rekonq.kcfg 4050c4a > src/settings/settings_tabs.ui eb775d5 > > Diff: http://git.reviewboard.kde.org/r/102330/diff > > > Testing > ------- > > compiles and works > > > Thanks, > > Johannes > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
