----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102423/#review6051 -----------------------------------------------------------
src/settings/generalwidget.cpp <http://git.reviewboard.kde.org/r/102423/#comment5323> I think you are assuming a bit too much (eg: what with file:// urls?) . Probably, the best implementation here is just using QUrl::fromUserInput(...text()) - Andrea On Aug. 24, 2011, 2:32 p.m., Furkan Üzümcü wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102423/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2011, 2:32 p.m.) > > > Review request for rekonq. > > > Summary > ------- > > Currently, when you type "www.google.com" in the home page line edit, it's > saved like that and not opened when you try to open your home page. This > patch fixes it. > > > Diffs > ----- > > src/settings/generalwidget.h 5a16e4f > src/settings/generalwidget.cpp 42f1f92 > > Diff: http://git.reviewboard.kde.org/r/102423/diff > > > Testing > ------- > > Compiles and works. > > > Thanks, > > Furkan > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
