----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102481/#review6235 -----------------------------------------------------------
Ship it! Seems perfect! Please, go ahead :) - Andrea On Aug. 31, 2011, 3 p.m., David Narváez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102481/ > ----------------------------------------------------------- > > (Updated Aug. 31, 2011, 3 p.m.) > > > Review request for rekonq. > > > Summary > ------- > > There are currently two families of methods handling reloads: one that uses > QWebView's reload method and one that does more sophisticated handling of the > about: scheme. This, apart from being an issue on its own, produces a bug > where reloading a tab from the Reload Tab and Reload All Tabs tab context > menu items cannot reload failed web pages while reloading it from the Reload > button in the toolbar can. > > The proposed patch modifies all 3 reloading methods (including one slot) by > adding a webReload(WebTab *) slot that will ultimately handle all reloads, > and modifying the workflow of the other 3 methods in the following way: > > - webReload() -> webReload(WebTab *) > - reloadTab(int) -> webReload(WebTab *) > - reloadAllTabs() -> reloadTab(int) -> webReload(WebTab *) > > > Diffs > ----- > > src/mainview.cpp b573894 > > Diff: http://git.reviewboard.kde.org/r/102481/diff > > > Testing > ------- > > To reproduced the bug mentioned above: > > 1. Disconnect from the internet (I disable networking in my laptop), open > rekonq, open 3 tabs and access any web page in those three tabs until you > have all three tabs displaying error pages (Host Not Found). > 2. Reconnect, and right click any tab, then do Reload Tab and Reload All > Tabs, nothing should happen > 3. Go to any tab and click the Reload button from the toolbar, you should be > able to reload the web page > > After applying the patch, you should be able to reload any tab from the tab > context menu or from the toolbar, and also reloading all failed tabs from the > Reload All Tabs item in the tab context menu. > > > Thanks, > > David > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
