----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102441/#review6592 -----------------------------------------------------------
i suggest you should create a new review request that just handles the "really search the web" part as tomorrow is string freeze and add it to the pasteAndGo function. src/urlbar/urlbar.cpp <http://git.reviewboard.kde.org/r/102441/#comment5827> the empty case will not happen, because the action is disabled if the clipboard is empty. furthermore i see no reason in proceeding if the clipboard is empty. - Johannes On Sept. 17, 2011, 9:46 a.m., Furkan Üzümcü wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102441/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2011, 9:46 a.m.) > > > Review request for rekonq. > > > Summary > ------- > > If the content of the clipboard is not a URL, the "Paste & Go" action's text > is changed to "Paste & Search". > > > Diffs > ----- > > src/urlbar/urlbar.h 7059725 > src/urlbar/urlbar.cpp e3f216d > > Diff: http://git.reviewboard.kde.org/r/102441/diff > > > Testing > ------- > > Compiles and works. > > > Thanks, > > Furkan > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
