----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102760/#review7037 -----------------------------------------------------------
This review has been submitted with commit 1e8c15e2bd291888f5330771901ff58b4039d559 by Andrea Di Menna to branch master. - Commit Hook On Oct. 3, 2011, 9:44 a.m., Andrea Di Menna wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102760/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2011, 9:44 a.m.) > > > Review request for rekonq and Andrea Diamantini. > > > Description > ------- > > The current hash mechanism used to generate thumbnails' filename (base64 > encoding) has the following issues: > 1) it can generate invalid chars for a filename (e.g. "/") > 2) it can generate too wide strings (base64 strings are 33% wider than the > starting string) > > This can lead to the impossibility to create a thumbnail for a specific URL > and hence to have a persistent loading icon in the favorites page. > > By using MD5 we get 32 hex chars strings (valid filenames). > Computation time to get an MD5 hash is negligible. > > You can try with the following URL: > > https://bugs.kde.org/buglist.cgi?query_format=advanced&short_desc_type=allwordssubstr&short_desc=&product=rekonq&component=general&version=unspecified&long_desc_type=allwordssubstr&long_desc=&bug_file_loc_type=allwordssubstr&bug_file_loc=&keywords_type=allwords&keywords=&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&emailassigned_to1=1&emailtype1=substring&email1=&emailassigned_to2=1&emailreporter2=1&emailcc2=1&emailtype2=substring&email2=&bugidtype=include&bug_id=&votes=&chfieldfrom=&chfieldto=Now&chfieldvalue=&cmdtype=doit&order=Reuse+same+sort+as+last+time&field0-0-0=noop&type0-0-0=noop&value0-0-0= > > > Diffs > ----- > > src/websnap.cpp d041156 > > Diff: http://git.reviewboard.kde.org/r/102760/diff/diff > > > Testing > ------- > > Compiled and working. > > > Thanks, > > Andrea Di Menna > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
