----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102768/#review7072 -----------------------------------------------------------
Did you test it just with "view source" katepart? Because rekonq seems working well eg with okularpart, but not with katepart. I'd like to understand this before merging such change. - Andrea Diamantini On Oct. 4, 2011, 7:47 a.m., Andrea Di Menna wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102768/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2011, 7:47 a.m.) > > > Review request for rekonq and Andrea Diamantini. > > > Description > ------- > > When the Save As action is invoked on a KParts document (e.g. view source > katepart) the WebTab's url is used to: > 1) set the filename in KFileDialog > 2) set the src url for the kio copy job > > The url is empty in such cases and the save action fails. > > I have changed the srcUrl to be the url set for the KParts document. > > > Diffs > ----- > > src/mainwindow.cpp 528ec21 > > Diff: http://git.reviewboard.kde.org/r/102768/diff/diff > > > Testing > ------- > > Compiled and working > > > Thanks, > > Andrea Di Menna > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
