> On Oct. 13, 2011, 4:55 p.m., Tirtha Chatterjee wrote: > > I think the idea of having pinned tabs kind of collides and makes redundant > > my work on tab grouping using sessions. I'd request to wait to merge this > > feature till 0.8 is released. After that, we can discuss in detail how to > > merge this smoothly while having tab-grouping. > > Furkan Üzümcü wrote: > If so, this patch becomes useless. :)
No, I wouldn't say useless, actually quite helpful. I think we can integrate this in a nice way with the tab-grouping thing. So I'll try to use this code, and merge these into my work. Thanks for the patch. - Tirtha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102839/#review7293 ----------------------------------------------------------- On Oct. 13, 2011, 2:47 p.m., Furkan Üzümcü wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102839/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2011, 2:47 p.m.) > > > Review request for rekonq. > > > Description > ------- > > This feature has become a "must have" for any browser. So I thought I could > do something about it. The patch works fine except a few glitches which I'm > hoping you can help me about. I do believe this patch isn't perfect. So > please help me improve it. > There are 2 problems. > 1- Open 2 tabs. While on the first tab pin the second one. And you'll se the > problem. This is the best way to tell you. > 2- Icons aren't shown right after pinning a tab. > > > Diffs > ----- > > src/application.cpp 6f9df43 > src/mainview.cpp 0cd61dd > src/rekonq.kcfg d29a5a3 > src/tabbar.h b4c816b > src/tabbar.cpp ea01ef9 > > Diff: http://git.reviewboard.kde.org/r/102839/diff/diff > > > Testing > ------- > > Compiles and works except some glitches. > > > Thanks, > > Furkan Üzümcü > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
