> On Nov. 22, 2011, 6:27 p.m., Yoann Laissus wrote: > > This event filter is complex enough :D > > I think it's better to group at the same place all the things related to a > > click on a KBookarkAction* > > So, this patch needs to be integrated in this big if (in the > > MouseReleaseEvent) : > > 509 if (watched != toolBar() && mouseEvent && mouseEvent->button() != > > Qt::MidButton) > > > > > > Andrea Diamantini wrote: > Bookmark thing. Yoann, can you please review and eventually merge this? > > Andrea Diamantini wrote: > :D > > Johannes Tröscher wrote: > what about adding a gci-task for splitting up the event filter? this > would improve readability of this code a lot... > > Furkan Üzümcü wrote: > We'd have to wait a long time for that. We can't add new tasks till > Decmeber 16 (or something like that). I talked to the student and he'll fix > it.
The task for the BookmarkToolBar refactoring is already in melange : http://www.google-melange.com/gci/task/view/google/gci2011/7141277 But I fear it can be a bit too difficult for a gci task. @Andrea : I will do that in the evening :) - Yoann ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103206/#review8397 ----------------------------------------------------------- On Nov. 22, 2011, 6:02 p.m., Furkan Üzümcü wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103206/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2011, 6:02 p.m.) > > > Review request for rekonq. > > > Description > ------- > > This is a Google Code-in 2011 task. Made by Hüseyin Zengin, GCI student. > > > Diffs > ----- > > src/bookmarks/bookmarkstoolbar.cpp 23af65c > > Diff: http://git.reviewboard.kde.org/r/103206/diff/diff > > > Testing > ------- > > Compiles and works. > > > Thanks, > > Furkan Üzümcü > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
