> On Nov. 27, 2011, 11:25 a.m., Andrea Diamantini wrote: > > Really nice! Well done! > > Andrea Diamantini wrote: > Sorry, I'm testing your patch and I really cannot understand. What is the > difference between "delete" and "forget" an entry? What's the use case to > just forget one? > > Yoann Laissus wrote: > When a website is visited twice, there is two history entries but only > one appears in the panel. > So "remove" only remove the selected entry and "forget" delete all the > entries of the selected website.
uhm... so I think that something like "Remove this entry" vs "Remove all occurrences" or something like that could be more appropriate. Apart from that, everything seems ok, as said with the first "ship it" - Andrea ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103255/#review8508 ----------------------------------------------------------- On Nov. 26, 2011, 4:46 p.m., Yoann Laissus wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103255/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2011, 4:46 p.m.) > > > Review request for rekonq. > > > Description > ------- > > Patch by Hüseyin Zengin, GCI student. > > > Diffs > ----- > > src/history/historypanel.h 5ca4fff > src/history/historypanel.cpp 8ba963e > > Diff: http://git.reviewboard.kde.org/r/103255/diff/diff > > > Testing > ------- > > > Thanks, > > Yoann Laissus > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
