> On Dec. 16, 2011, 9:17 p.m., Andrea Diamantini wrote: > > The "open in new tab feature" has been explicitely requested times ago. Why > > are you going to "force" it? Moreover, you probably just need to add the > > home button in the (actual) urlbar via the "configure toolbars" contextual > > menu. > > I don't see the need for this change.
Stupid me, IRC discussion explained me everything and now I see the bug when setting a custom shortcut for the "home" containing CTRL. - Andrea ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103428/#review9019 ----------------------------------------------------------- On Dec. 16, 2011, 1:43 p.m., Thomas Murach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103428/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2011, 1:43 p.m.) > > > Review request for rekonq. > > > Description > ------- > > Functionality: see summary. > Concerning the code: As far as I've seen, there is no "go to home page" > button or anything like that. So the only way to visit the home page is to > use a shortcut or to configure this as new tab action. Therefore it's not > necessary anymore to care about middle mouse clicks or Ctrl+... events. > That's why I also changed the argument list of MainWindow::homePage(). > If I'm mistaken on that, please correct me. > > > Diffs > ----- > > src/mainwindow.h 8d827b0 > src/mainwindow.cpp 6b15385 > > Diff: http://git.reviewboard.kde.org/r/103428/diff/diff > > > Testing > ------- > > > Thanks, > > Thomas Murach > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
