----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103450/#review9585 -----------------------------------------------------------
src/bookmarks/bookmarkmanager.h <http://git.reviewboard.kde.org/r/103450/#comment7855> Never make attributes public. You should use the owner() and manager() accessors instead. src/urlbar/bookmarkwidget.cpp <http://git.reviewboard.kde.org/r/103450/#comment7859> If you do what I suggest in setupFolderComboBox(), no need of those three if anymore. src/urlbar/bookmarkwidget.cpp <http://git.reviewboard.kde.org/r/103450/#comment7857> Don't hardcode the value. You can use KBookmarkManager::toolbar() to get the root bookmark of the toolbar. Also, if the root folder already contains this specific folder, it shouldn't appear twice. - Yoann Laissus On Jan. 5, 2012, 3:16 p.m., Yusuf TEZCAN wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103450/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2012, 3:16 p.m.) > > > Review request for rekonq. > > > Description > ------- > > A combobox which contains root folders to move the current bookmark in it. I > am a GCI-Student who wrote this patch. > > > Diffs > ----- > > src/bookmarks/bookmarkmanager.h 0254b19 > src/urlbar/bookmarkwidget.h e294bf1 > src/urlbar/bookmarkwidget.cpp c144b8d > > Diff: http://git.reviewboard.kde.org/r/103450/diff/diff > > > Testing > ------- > > > Thanks, > > Yusuf TEZCAN > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
