> On Jan. 10, 2012, 6:25 p.m., Andrea Diamantini wrote: > > src/sessionmanager.cpp, line 308 > > <http://git.reviewboard.kde.org/r/103658/diff/1/?file=46221#file46221line308> > > > > The for loop here is useless if you can identify your window data. To > > do this I guess you can use elementsByTagName and hasAttribute QDomElements > > methods. > > David Narváez wrote: > Still don't get it: I _am_ using elementsByTagName to iterate over the > list of windows and using the attribute method a couple of lines later to > match the name of the window. The only way I see I could eliminate this for > loop is using some XML Query (e.g., XPath) to query for something like > window[name=the-window-name] which I think is an overkill if iterating over > an already parsed XML document with just a few window nodes.
ok. - Andrea ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103658/#review9717 ----------------------------------------------------------- On Jan. 10, 2012, 3:42 p.m., David Narváez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103658/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2012, 3:42 p.m.) > > > Review request for rekonq and Tirtha Chatterjee. > > > Description > ------- > > This patch implements session management (see > http://techbase.kde.org/Development/Tutorials/Session_Management). Most of > the ideas are taken from Konsole, which is also a KUniqueApplication but > manages session restoring correctly. Notice that the new code in Session > Manager triplicates some code from other functions (mostly dealing with > loading the session DOM Document and restoring tabs), so I think that if this > patch is accepted, a refactoring of the SessionManager code is in order (or > maybe do the refactoring before this patch?). I can take a shot at the > refactoring if needed. > > > Diffs > ----- > > src/main.cpp a9082d7 > src/mainwindow.h 04a59a1 > src/mainwindow.cpp 98936e9 > src/sessionmanager.h d0d7efd > src/sessionmanager.cpp 20b3501 > src/application.cpp a09fc26 > > Diff: http://git.reviewboard.kde.org/r/103658/diff/diff > > > Testing > ------- > > Test #1: Desktop restoration > 1) Open Rekonq in one Desktop > 2) Change to another desktop > 3) Log out and back in > > Rekonq should not appear in the desktop you are at, but in the desktop you > were when you called it. > > Test #2: Activities restoration > 1) Open two activities > 2) Open two different Rekonq windows, one in each activity, with different > URLs > 3) Log out and back in > > Rekonq should be restore in both activities with the URLs you loaded before > logging out > > Other tests: > 1) Do Test #2, then open a new rekonq window - this tests changes in the > Application::newInstance() method. > 2) Crash the session (e.g., killall rekonq) and open rekonq again - in this > case no desktop/activities restoration should take place (haven't figured out > how to do this) > > > Thanks, > > David Narváez > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
