> On Jan. 19, 2012, 8:41 a.m., Andrea Diamantini wrote: > > src/sessionmanager.cpp, line 47 > > <http://git.reviewboard.kde.org/r/103722/diff/1/?file=46918#file46918line47> > > > > Is there a reason to pass a local member variable here?
readSessionDocument is not a method, so m_sessionFilePath is not a member variable. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103722/#review9939 ----------------------------------------------------------- On Jan. 18, 2012, 5:18 a.m., David Narváez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103722/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2012, 5:18 a.m.) > > > Review request for rekonq. > > > Description > ------- > > Factor out all code that loads the DOM Document, and use proper calls in each > method. The idea is pretty straightforward, I guess we only need to agree on > the style (e.g., should it be a private method or just a function?) > > Can this go into 0.9? Or is it considered a feature? > > > Diffs > ----- > > src/sessionmanager.cpp e67012a > > Diff: http://git.reviewboard.kde.org/r/103722/diff/diff > > > Testing > ------- > > I've been using this for about a week, no changes wrt to previous behavior. I > started new sessions, restored previous sessions, crashed sessions... I think > those are all use cases that cover these lines of code. > > > Thanks, > > David Narváez > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
