> On Jan. 25, 2012, 8:48 p.m., Andrea Diamantini wrote: > > The different ways to retrieve the mainview pointer IS the motivation > > because there are 3 methods. Refactor this code means consider this part, > > not just remove two calls and substitute them. Testing has obviously to be > > done for crash restore, session restore, private browsing restore. > > David Narváez wrote: > I'm not clear if this means you do not agree with the patch or you do > agree that there's nothing else we can factor out from the original code.
:D I just think that cutting out the mainview pointer thingy cannot be done without conseguences. So, the patch cannot be merged AS IS. But I think there could be a couple of solutions to factor anyway this code. - Andrea ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103755/#review10078 ----------------------------------------------------------- On Jan. 21, 2012, 6:38 p.m., David Narváez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103755/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2012, 6:38 p.m.) > > > Review request for rekonq. > > > Description > ------- > > Factor out the code to restore tabs into a main view. This is as much as I > think can be factored out of the tab restoration code because, even when each > call to restoreTabsInMainView is surrounded by a for loop, each loops has a > different way of getting the MainView pointer, but if someone has a better > idea I'm open to suggestions. > > > Diffs > ----- > > src/sessionmanager.cpp 74e9603 > > Diff: http://git.reviewboard.kde.org/r/103755/diff/diff > > > Testing > ------- > > Usual test cases: > 1) Crash the session with killall rekonq > 2) Restore with logout/log back in > 3) Close windows and restore > > > Thanks, > > David Narváez > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
