> On Feb. 10, 2012, 9:03 a.m., Andrea Diamantini wrote: > > src/application.cpp, line 208 > > <http://git.reviewboard.kde.org/r/103905/diff/1/?file=49059#file49059line208> > > > > Sorry Yoann, I yet cannot reproduce your bug. Anyway, I'd like to not > > propose again the "bugged habit" to postLaunch things. Can't we just let > > showMessageBar a private slot and singleShot it with 1 second of delay? > > > > PS: please, rebase branches before committing to master, to let history > > be clean. > > Yoann Laissus wrote: > It seems to be a Kubuntu related issue. I can reproduce the bug on > Kubuntu 11.10 (KDE 4.7 and another PC with KDE 4.8) but not on Fedora (KDE > 4.7) ... > I'll try to make a better and less intrusive patch without the need of a > timer. > > Oops sorry for master, forget the --rebase. > > Andrea Diamantini wrote: > Do you think a change like this can work also there? > > ----- patch start here ----- > diff --git a/src/application.cpp b/src/application.cpp > index d8044e2..1bf7b55 100644 > --- a/src/application.cpp > +++ b/src/application.cpp > @@ -205,7 +205,7 @@ int Application::newInstance() > if (isRekonqCrashed && isFirstLoad) > { > loadUrl(KUrl("about:closedTabs"), Rekonq::NewWindow); > - mainWindow()->currentTab()->showMessageBar(); > + QTimer::singleShot(1000, mainWindow()->currentTab(), > SLOT(showMessageBar())); > } > > if (areThereArguments) > diff --git a/src/webtab.h b/src/webtab.h > index ccbd7a8..b875e4f 100644 > --- a/src/webtab.h > +++ b/src/webtab.h > @@ -93,7 +93,6 @@ public: > > void setPart(KParts::ReadOnlyPart *p, const KUrl &u); > > - void showMessageBar(); > > private Q_SLOTS: > void updateProgress(int progress); > @@ -103,6 +102,8 @@ private Q_SLOTS: > void showRSSInfo(const QPoint &pos); > void showSearchEngine(const QPoint &pos); > void openSearchEngineAdded(); > + > + void showMessageBar(); > > Q_SIGNALS: > void loadProgressing(); > ----- patch ends here -----
Sorry, I forgot this review request. The patch you have committed works just fine :) - Yoann ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103905/#review10479 ----------------------------------------------------------- On Feb. 10, 2012, 7:42 a.m., Yoann Laissus wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103905/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2012, 7:42 a.m.) > > > Review request for rekonq. > > > Description > ------- > > Restore the old method to fix the recover on crash bar if rekonq is maximised > at startup. > > > Diffs > ----- > > src/application.h 2689e3f > src/application.cpp 18d19d9 > > Diff: http://git.reviewboard.kde.org/r/103905/diff/ > > > Testing > ------- > > > Screenshots > ----------- > > > http://git.reviewboard.kde.org/r/103905/s/428/ > > > Thanks, > > Yoann Laissus > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
