----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104197/#review11248 -----------------------------------------------------------
src/bookmarks/bookmarkmanager.h <http://git.reviewboard.kde.org/r/104197/#comment9025> You should probably return QL1S("app..."); here. This is a minor speed improvement cause of faster QLatin1String char* manipulation + its QString copy ctor. - Andrea Diamantini On March 8, 2012, 7:05 p.m., David Narváez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104197/ > ----------------------------------------------------------- > > (Updated March 8, 2012, 7:05 p.m.) > > > Review request for rekonq. > > > Description > ------- > > As discussed in the mailing list, this changes the MIME type to > x-rekonq-bookmark and centralizes all references to that MIME type in one > static method. > > > Diffs > ----- > > src/bookmarks/bookmarkmanager.h 0de128a > src/bookmarks/bookmarkstoolbar.cpp fc9a32d > src/bookmarks/bookmarkstreemodel.cpp 534e969 > src/webview.cpp 019eb42 > > Diff: http://git.reviewboard.kde.org/r/104197/diff/ > > > Testing > ------- > > Drag and drop bookmarks to make sure the MIME types are interpreted correctly. > > Please notice that this could break any other application that wants to > interact with rekonq bookmarks. > > > Thanks, > > David Narváez > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
