----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104257/#review11363 -----------------------------------------------------------
I'm not at home at the moment, but I know there is a bug in current history management which I haven't been able to track. Can I have this night (UTC -5) to track that bug then test this patch to see if it is solved? src/history/historymanager.cpp <http://git.reviewboard.kde.org/r/104257/#comment9097> Do we really want to keep commented code? We can always use VCS history to get these lines if needed. - David Narváez On March 13, 2012, 10:26 a.m., Andrea Diamantini wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104257/ > ----------------------------------------------------------- > > (Updated March 13, 2012, 10:26 a.m.) > > > Review request for rekonq. > > > Description > ------- > > New History Manager, NO MORE QWebHistoryInterface based. > > We are just saving datas on our own, I don't like QtWebKit APIs > to do it. We now call addHistoryEntry(url, title) > on loadFinished. > Data structure will remain the same as usual, but I think API > is better and data are now saved when we really have them > ready. > > > Diffs > ----- > > src/history/historymanager.h d4531e5cb28ca38f9b9755178b53d4ccb1548db2 > src/history/historymanager.cpp 602e46067be18668cafcf25dd1027355342da2e9 > src/history/historymodels.h 9c3bfc365d9fb8ec290ae8ed417e07d236ffe94a > src/history/historymodels.cpp 160540540c1e5925e03541bcd2537ac2a4f9e2dc > src/mainview.cpp b164c72bc78baaa3d1539ab5501810213e7d11db > src/protocolhandler.cpp 4744e766bb6d57ff07b8d001d74108e48183f022 > src/webtab.h b0c849ef85fd55c17bcc9ba350539752b013af8b > src/webtab.cpp 8db44dd8065c3deef12f99acb55be5ee3e320b38 > > Diff: http://git.reviewboard.kde.org/r/104257/diff/ > > > Testing > ------- > > > Thanks, > > Andrea Diamantini > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
