----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105022/#review14106 -----------------------------------------------------------
src/application.cpp <http://git.reviewboard.kde.org/r/105022/#comment11152> This macro takes 1 parameter. MSVC pre-processor won't allow it to be empty. src/bookmarks/bookmarkowner.cpp <http://git.reviewboard.kde.org/r/105022/#comment11156> Same as first comment. src/mainview.h <http://git.reviewboard.kde.org/r/105022/#comment11153> MSVC does not allow a template declaration with an undefined template argument, so we need to have TabHistory defined. src/mainview.h <http://git.reviewboard.kde.org/r/105022/#comment11154> HistoryItem is also defined in "historymanager.h", so no need to forward delcare it. src/opensearch/suggestionparser.h <http://git.reviewboard.kde.org/r/105022/#comment11157> MSVC warns about having two default constructors, as the constructor below this one can also be used as a default ctor. src/webpage.cpp <http://git.reviewboard.kde.org/r/105022/#comment11155> Same as first comment. - Andrius da Costa Ribas On May 24, 2012, 2:03 a.m., Andrius da Costa Ribas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105022/ > ----------------------------------------------------------- > > (Updated May 24, 2012, 2:03 a.m.) > > > Review request for kdewin, rekonq and Andrea Diamantini. > > > Description > ------- > > Some small fixes for MSVC build (detailed comments in the review request diff > view). > > > Diffs > ----- > > src/application.cpp ef6c208 > src/bookmarks/bookmarkowner.cpp be28448 > src/mainview.h a80ba52 > src/opensearch/suggestionparser.h c8a61b9 > src/webpage.cpp ce1151d > > Diff: http://git.reviewboard.kde.org/r/105022/diff/ > > > Testing > ------- > > Tested using MSVC 2010. > > > Thanks, > > Andrius da Costa Ribas > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
