----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105124/#review14354 -----------------------------------------------------------
Very nice, but for the warning icon. Can you please remove it? We probably just exaggerated with them... Last thing: did you know the same html page is used for file/ftp pages? Did you check also loading your home page there? - Andrea Diamantini On May 31, 2012, 9:50 p.m., Anton Kreuzkamp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105124/ > ----------------------------------------------------------- > > (Updated May 31, 2012, 9:50 p.m.) > > > Review request for rekonq and Andrea Diamantini. > > > Description > ------- > > Add a background-image, a box-shadow and a warning-symbol to indicate it's a > error-page. See screenshot. > > I've created an alternative version, with a more Plasma-like box, I've posted > it in a similar review-request for the new tab page > (https://git.reviewboard.kde.org/r/105123/). > > > Diffs > ----- > > src/data/rekonqinfo.html 35fade4 > src/webpage.cpp bc4d0aa > > Diff: http://git.reviewboard.kde.org/r/105124/diff/ > > > Testing > ------- > > > Screenshots > ----------- > > The error page with this patch > http://git.reviewboard.kde.org/r/105124/s/586/ > > > Thanks, > > Anton Kreuzkamp > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
