----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105184/#review14562 -----------------------------------------------------------
src/mainview.cpp <http://git.reviewboard.kde.org/r/105184/#comment11510> Just to get rid of another rApp... call, isn't the same concept doing a check like "index == currentIndex()" ? - Andrea Diamantini On June 8, 2012, 12:27 p.m., David Narváez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105184/ > ----------------------------------------------------------- > > (Updated June 8, 2012, 12:27 p.m.) > > > Review request for rekonq. > > > Description > ------- > > This makes sense conceptually, and in practice fixes a bug that has crashed > rekonq in my end for about a week yet I'm unclear about how did I get my > session to be in this state - which is basically more than one window with at > least one of them without tabs. > > > Diffs > ----- > > src/mainview.cpp a9bc540 > > Diff: http://git.reviewboard.kde.org/r/105184/diff/ > > > Testing > ------- > > Hard to test. Should you be able to create a session file with one window > without tabs and restore rekonq from that, if the URL of another window > (obviously with tabs) changes, the MainView::webViewUrlChanged slot will > crash rekonq. > > > Thanks, > > David Narváez > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
