> On July 26, 2012, 8:27 a.m., Andrea Diamantini wrote:
> > I don't understand your changes: this is my kuriikwsfilterrc file.
> > ---
> > [$Version]
> > update_info=kuriikwsfilter.upd:post-kde3.1/cvs
> > 
> > [General]
> > DefaultSearchEngine=google
> > EnableWebShortcuts=true
> > FavoriteSearchEngines=youtube,google,wikipedia,wikit
> > KeywordDelimiter=:
> > UseSelectedProvidersOnly=true
> > ---
> > Moreover, I'm using ArchLinux and search engines are working here.
> > To really fix and improve this code you should REMOVE deprecated access to 
> > config file and use KUriFilterData API instead.
> > 
> > The other fix needs to be posted in a different request and just better 
> > tested.

Moreover, the problem reported here in Chakra 
(https://bugs.kde.org/show_bug.cgi?id=303872) "autoresolved" itself.


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105732/#review16461
-----------------------------------------------------------


On July 25, 2012, 10:39 p.m., Johannes Tröscher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105732/
> -----------------------------------------------------------
> 
> (Updated July 25, 2012, 10:39 p.m.)
> 
> 
> Review request for rekonq and Andrea Diamantini.
> 
> 
> Description
> -------
> 
> the names of two entries in the code parsing the config file for search 
> engines seem to be wrong. rekonq will not find the default search engine and 
> the favored ones because of this. i've changed the code to use the right 
> entries.
> 
> furthermore there seems to be a bug that causes the completition widget only 
> to be shown from the time on it lost it's focus once and gained it again. 
> i've addressed that as well and changed the code to show the completition 
> widget also on keypress events.i hope that's ok ;)
> 
> bugs occurred in chakra linux and where also confirmed by arch-users.
> 
> 
> This addresses bug 303872.
>     /show_bug.cgi?id=303872
> 
> 
> Diffs
> -----
> 
>   src/opensearch/searchengine.cpp aef06a7 
>   src/urlbar/urlbar.cpp 21debce 
> 
> Diff: http://git.reviewboard.kde.org/r/105732/diff/
> 
> 
> Testing
> -------
> 
> compiles and works
> 
> 
> Thanks,
> 
> Johannes Tröscher
> 
>

_______________________________________________
rekonq mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/rekonq

Reply via email to