> On Oct. 17, 2012, 12:07 p.m., David Narváez wrote: > > I'm not sure why am I under the impression that adjam does not use > > activities. Anyhow, I'll pitch in with a couple observations: > > > > First of all, it is cool to see activities integration in rekonq (I'm sure > > at least mathieson has been asking for this) and I hope we can get more of > > this. > > > > On the other hand, the target audience of this review is probably not > > related to the SLC concept so besides mentioning that you can use the SLC > > applet, it would be useful to give an overview of what does that do and > > explain how does that make Rekonq a better browser etc. > > > > Another comment, and this applies to all reviews in the platform, not this > > one in particular, is the Testing Done. People seem to think it is a yes/no > > question or answer "Works" or "Compiles". According to ReviewBoard > > documentation "The Testing Done field describes how this change has been > > tested [...] This should cover any and all testing scenarios that have been > > done, in order to help reviewers feel more confident about the stability > > and design of the change." > > > > Now, my review: > > > > I patched my Rekonq master (btw, you probably want to specify that in the > > branch field) and was unable to configure Rekonq with my current > > KActivities version (6.0.0) so I updated KActivities and Nepomuk Core to > > latest master and was able to compile everything. Is that intended? I see > > the _OPTIONAL cmake macro used there, but I'm not sure why did it fail - I > > could test that again if you need me to. After installing the patched > > Rekonq, I can only report it doesn't break, but I'm not sure how to test if > > it is doing anything with the resources, is there a sparql query I can > > throw into, e.g., NepSaK to see this working in the backend? > > > > Thanks.
Kinda expected that people follow planetkde - seemed like other applications' reviewers (okular, gwenview, kate ...) knew about SLC. Will update the description above. > I could test that again if you need me to Can you give me the output? - Ivan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106912/#review20495 ----------------------------------------------------------- On Oct. 16, 2012, 1:38 p.m., Ivan Čukić wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106912/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2012, 1:38 p.m.) > > > Review request for rekonq and Andrea Diamantini. > > > Description > ------- > > Rekonq reports the open/close document events to activity manager daemon. > Side-effect - support for Share-Like-Connect applet. > > > Diffs > ----- > > CMakeLists.txt 030f0fb > config-kactivities.h.cmake PRE-CREATION > src/CMakeLists.txt 6c27376 > src/mainview.h 89ee36e > src/mainview.cpp 15e0d5e > > Diff: http://git.reviewboard.kde.org/r/106912/diff/ > > > Testing > ------- > > Yes, with multiple tabs and separate windows > > > Thanks, > > Ivan Čukić > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
