----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107662/#review23319 -----------------------------------------------------------
Ship it! Seems good to me, too. Many thanks for it. Just one side note about. Please, DON'T commit it as I'm going to merge in rekonq this week the rekonq2 project. I'll personally take care of merging your patch as soon as the merge is complete. Regards, - Andrea Diamantini On Dec. 11, 2012, 6:21 a.m., Vedant Agarwala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107662/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2012, 6:21 a.m.) > > > Review request for rekonq. > > > Description > ------- > > There was a bug due to which, when we typed a url like "goal" and pressed > ctrl+enter, the .com was not appended. Actually, two urls were being opened > in quick succession, one with the .com appended, another one without it > (taken from the completion list's url). > > This patch fixes it, by not progressing to load the list's url, and stopping > after emitting the appended url. > > > Diffs > ----- > > src/urlbar/completionwidget.cpp 04f7bad > > Diff: http://git.reviewboard.kde.org/r/107662/diff/ > > > Testing > ------- > > Tested manually. Works. > > > Thanks, > > Vedant Agarwala > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
