> On Feb. 10, 2013, 12:35 p.m., Andrea Diamantini wrote: > > Hi Dimitrios, and many thanks for your patches. I had a terrible cold this > > week, so that I needed some time more than usual to review. You probably > > just noticed your first patch has just been merged. About this... I think > > you reverted the "settings" logic. You should add a "add tabs in the > > foreground" option, disabled by default, so that user wanting it, enable > > it! I think it's the easiest set. Can you take care of it or should I do it > > for you, given your patch?
Hi Andrea, I tried to add this option the way Konqueror does it, but I now see the inconsistency in my patch. Your way is better, so I'll be uploading a new patch shortly. I hope you're feeling better. I should send a "Get Well" card; rekonq is awesome! - Dimitrios ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108801/#review27116 ----------------------------------------------------------- On Feb. 6, 2013, 1:47 p.m., Dimitrios Christidis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108801/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2013, 1:47 p.m.) > > > Review request for rekonq and Dimitrios Christidis. > > > Description > ------- > > Adds a new configuration option (disabled by default) to open links in new > tabs in the foreground. > > > This addresses bug 313794. > /show_bug.cgi?id=313794 > > > Diffs > ----- > > src/rekonq.kcfg 6303dcd > src/settings/settings_tabs.ui 5b367a8 > src/tabwindow/tabwindow.cpp d0e6dbc > > Diff: http://git.reviewboard.kde.org/r/108801/diff/ > > > Testing > ------- > > There are multiple calls to TabWindow::loadUrl() with Rekonq::NewTab, but I > think I got them all. Tested with the new setting enabled and disabled. > > + click on link with middle mouse button > + right-click on link, then open in new tab > + same actions on the bookmarks toolbar and about: pages > + right-click on image, middle-click on "View Image" > > Loading an external URL always focuses the new tab. Same with middle-clicking > on a link in the search bar. > > > Thanks, > > Dimitrios Christidis > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
