----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108888/#review27272 -----------------------------------------------------------
This review has been submitted with commit af4bbb87a353d8bd5886e29246ba7c65b24b8c34 by Andrea Diamantini to branch master. - Commit Hook On Feb. 10, 2013, 1:42 p.m., Dimitrios Christidis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108888/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2013, 1:42 p.m.) > > > Review request for rekonq and Dimitrios Christidis. > > > Description > ------- > > When right-clicking on the main toolbar, items "Bookmarks Toolbar" and > "Configure Main ToolBar" appear multiple times. To be precise, they appear > once for every tab that is currently open. > > This bug was introduced in commit 2d8de46a. Each WebWindow creates a new > collection, so the loop in MainToolBar::showCustomContextMenu() finds the > actions mentioned above multiple times. > > I'm attaching a simple diff as a proof-of-concept. Please advise me on what > is the correct way to address this issue. Then, I'll create a proper commit > patch. > > > Diffs > ----- > > src/webwindow/maintoolbar.cpp ee667ec > > Diff: http://git.reviewboard.kde.org/r/108888/diff/ > > > Testing > ------- > > > Thanks, > > Dimitrios Christidis > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
