> On April 23, 2013, 3:01 p.m., Andrea Diamantini wrote: > > I tested this and I don't have any sort of gain from. Or at least the > > "cluttering" in my pinned/unpinned tab (half icon shown) is not removed.
by cluttering I meant when I unpin any tab it did not unpin correctly, other than the half icon thing I was referring to the disorganized unpinning! Ive shown it in the attachement. ->Open 3 tabs ->pin all the tabs ->unpin the first tab The result is what you see in the attachment. - mayank ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109854/#review31454 ----------------------------------------------------------- On April 23, 2013, 6:24 p.m., mayank jha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109854/ > ----------------------------------------------------------- > > (Updated April 23, 2013, 6:24 p.m.) > > > Review request for rekonq. > > > Description > ------- > > Just changed the position of setTabData(false); in the function unpinTab() to > a position similar as in pinTab() > > > This addresses bug 317798. > /show_bug.cgi?id=317798 > > > Diffs > ----- > > src/tabwindow/tabbar.cpp 7363d96 > > Diff: http://git.reviewboard.kde.org/r/109854/diff/ > > > Testing > ------- > > Tests done and it works fine!! > > > File Attachments > ---------------- > > cluttered tabs > http://git.reviewboard.kde.org/media/uploaded/files/2013/04/23/rek.png > > > Thanks, > > mayank jha > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
