-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115161/
-----------------------------------------------------------
(Updated March 4, 2014, 8:14 p.m.)
Review request for rekonq and Andrea Diamantini.
Repository: rekonq
Description (updated)
-------
when typing in the urlbar the first item ist not highlighted after the second
letter.
due to the change in commit f0b2b230e1cd4d35f2a95c3bad94e31ecdd70de1 the
widgets in the completion list are not deleted immediatelly.
when trying to highlight the widget at index 0, a search for the widget with
the object name "0" is done, but because the widget might not be deleted, the
old widget with the object name "0" will be found.
this patch sets the object name of the widget to an empty string (""), befor
calling deleteLater().
when new suggestions are added to the list, there will be only one with the
name "0", even if the old ones are not yet deleted.
Diffs
-----
src/urlbar/completionwidget.cpp 51ebd9e
src/urlbar/completionwidget.cpp 51ebd9e
src/urlbar/completionwidget.cpp 51ebd9e
Diff: https://git.reviewboard.kde.org/r/115161/diff/
Testing
-------
compiled and checked if the highlighting works again
File Attachments
----------------
before
https://git.reviewboard.kde.org/media/uploaded/files/2014/03/04/3562549b-de70-4b71-8372-61b8db3f85d0__before.png
after
https://git.reviewboard.kde.org/media/uploaded/files/2014/03/04/74792425-6579-4d9b-9118-7649b3a3633b__after.png
Thanks,
Mathias Kraus
_______________________________________________
rekonq mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/rekonq
